Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatability with JSON:API 1.1 #89

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

Art4
Copy link
Owner

@Art4 Art4 commented Oct 27, 2023

This PR should actually complement tests that prove compatibility with version 1.1.

However, it turns out that the library is not open enough for newly introduced properties. We have to correct this in another PR.

@Art4 Art4 added this to the 1.2.0 milestone Oct 27, 2023
@Art4 Art4 self-assigned this Oct 27, 2023
@Art4 Art4 linked an issue Oct 27, 2023 that may be closed by this pull request
@Art4 Art4 linked an issue Nov 28, 2023 that may be closed by this pull request
@Art4 Art4 linked an issue Nov 28, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (593b78e) 100.00% compared to head (83bddb0) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                v1.x       #89   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       297       298    +1     
===========================================
  Files             29        29           
  Lines            626       627    +1     
===========================================
+ Hits             626       627    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 merged commit 2ba023c into v1.x Nov 28, 2023
14 checks passed
@Art4 Art4 deleted the 83-check-compatability-with-json-api-11 branch November 28, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove twitter badge from README.md Check compatability with JSON-API 1.1
2 participants